EvalCtxt::commit_if_ok don't inherit nested goals by lcnr · Pull Request #118243...
source link: https://github.com/rust-lang/rust/pull/118243
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
EvalCtxt::commit_if_ok don't inherit nested goals #118243
Conversation
Contributor
we use it to check whether an alias is rigid, so we want to avoid considering an alias rigid simply because the inference constraints from normalizing it caused another nested goal fail
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
labels
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
Got a test for this? |
Contributor
Author
|
nope, it's mostly a non issue as you only get inference constraints from normalizing if the associated type is wf/implements its trait 🤔 don't think this is more than a purely theoretical issue |
Contributor
Author
|
and a perf improvement |
|
ok, r=me then |
Contributor
Author
|
@bors r=compiler-errors |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK