3

Separate `NaN`/`Inf` floats with `_` by compiler-errors · Pull Request #118271 ·...

 5 months ago
source link: https://github.com/rust-lang/rust/pull/118271
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Separate NaN/Inf floats with _ #118271

Conversation

r? RalfJung

Fixes #118221

No test 🤷 unless you know a good way to print an ImmTy in a unit test?

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Nov 24, 2023

Member

Miri is printing floats, that's how we noticed... so once rust-lang/miri#3185 propagates there will be a test.

Looks good, thanks!
@bors r+ rollup

Contributor

📌 Commit b601b40 has been approved by RalfJung

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 25, 2023

bors

merged commit a663bb9 into

rust-lang:master

Nov 25, 2023

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Nov 25, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

No reviews

Assignees

RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

rustc_middle: ImmTy's Display implementation adds a weird-looking suffix to special floating point values.

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK