10

rustdoc: speed up processing of cross-crate fns to fix a perf regression by fmea...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/116195
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Collaborator

Finished benchmarking commit (935f41f): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 3
Improvements ✅
(primary)		 -0.4% [-0.8%, -0.2%] 9
Improvements ✅
(secondary)		 -0.6% [-0.9%, -0.2%] 19
All ❌✅ (primary) -0.4% [-0.8%, -0.2%] 9

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.103s -> 631.156s (-0.15%)
Artifact size: 317.29 MiB -> 317.35 MiB (0.02%)

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK