Move `needless_raw_string_hashes` to `pedantic` by Alexendoo · Pull Request #114...
source link: https://github.com/rust-lang/rust-clippy/pull/11415
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
IMO it doesn't improve code enough to be warn by default. It seems to be unclear to some also, but that can probably be remedied separately
changelog: Moved [needless_raw_string_hashes] to pedantic (Now allow-by-default)
#11415
r? @flip1995
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label
Member
|
I'm fine with pedantic. Not sure what's wrong in #11402 though, as removing hashes should make no difference unless there's a |
Member
Author
|
My guess is people are removing the |
added the beta-nominated Nominated for backporting to the compiler in the beta channel. label
Member
|
Oh I completely missed this PR. Is this and the Backport still required with the other PR merged? |
Member
|
@bors r+ Reading through the issues, I figure this is required/wanted. |
Member
|
I'm leaning towards letting this change ride the release train without a backport. This lint is already in stable and I don't think the FN/confusion is so bad that we need a beta backport for this. However I'll cherry-pick this commit, so that it at least get's into 1.74. |
added beta-accepted Accepted for backporting to the compiler in the beta channel.
and removed beta-nominated Nominated for backporting to the compiler in the beta channel.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
</div
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK