Print omitted frames count for short backtrace mode by chenyukang · Pull Request...
source link: https://github.com/rust-lang/rust/pull/112843
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Member
Fixes #111730
Collaborator
|
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
Collaborator
|
|
Warning added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
labels
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
This comment has been minimized.
Member
Author
|
@rustbot ready |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Contributor
|
|
The latest upstream changes (presumably Member
Author
|
@rustbot ready |
Contributor
|
☔ The latest upstream changes (presumably #113176) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
@rustbot ready |
Contributor
|
Seems m-ou-se's comments were addressed! |
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
This comment has been minimized.
Contributor
|
💔 Test failed - checks-actions |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Contributor
|
Hmm, one more go. If this still doesn't pass then I think we should reassess this and approach it more systematically. @bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
|
|
Test successful - Collaborator
|
Finished benchmarking commit (d4145ee): comparison URL. Overall result:
|
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
Regressions  (secondary) |
6.1% | [6.1%, 6.1%] | 1 |
Improvements  (primary) |
-0.4% | [-0.4%, -0.4%] | 1 |
| Improvements (secondary) |
- | - | 0 |
| All (primary) |
-0.4% | [-0.4%, -0.4%] | 1 |
Max RSS (memory usage)
Results
Cycles
Results
Binary size
Results
Bootstrap: 653.169s -> 653.113s (-0.01%)
Contributor
|
That's a really wild shift... |
Member
Author
Yep, the hard thing for strip backtrace message is different arch may have trivial difference, and I don't have a x64_linux in my local env :( |
Member
Author
Interesting... |
Member
|
Seems like the start of noise:  @rustbot label: perf-regression-triaged |
added the perf-regression-triaged The performance regression has been triaged. label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK