2

Don't say that a type is uncallable if its fn signature has errors in it by comp...

 9 months ago
source link: https://github.com/rust-lang/rust/pull/113578
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

This is fallout from #106309, where we don't consider param-env candidates that reference errors because they unify with everything. This means, however, that we don't consider an APIT like impl Fn(MissingType) isn't considered to implement Fn, for example.

We can double-check that with a weaker heuristic extract_callable_info, and suppress the knock-down error using that.

Fixes #113566

compiler-errors

changed the title Don't say that a type is uncallable if its signature has errors in it

Don't say that a type is uncallable if its fn signature has errors in it

Jul 11, 2023

Collaborator

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jul 11, 2023

This comment has been minimized.

Contributor

@bors r+ rollup

Contributor

pushpin Commit c0c2d39 has been approved by b-naber

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Jul 25, 2023

bors

merged commit a6bf68d into

rust-lang:master

Jul 26, 2023

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Jul 26, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

b-naber

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.73.0

Development

Successfully merging this pull request may close these issues.

Confusing diagnostic when argument type in impl FnOnce() is not found

5 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK