7

Make "consider importing" consistent for macros by MU001999 · Pull Req...

2 years ago

source link: https://github.com/rust-lang/rust/pull/112452
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

neoserver,ios ssh client

Make "consider importing" consistent for macros #112452

Conversation

Contributor

Collaborator

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Contributor

r=me with the nit addressed.
@rustbot author

added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Contributor

Thanks!
@bors r+

MU001999 reacted with heart emoji

Contributor

Commit 5bd8ba8 has been approved by petrochenkov

It is now in the queue for this repository.

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Contributor

Testing commit 5bd8ba8 with merge d0ee190...

Contributor

Test successful - checks-actions
Approved by: petrochenkov
Pushing d0ee190 to master...

added the merged-by-bors This PR was explicitly merged by bors label

merged commit d0ee190 into

rust-lang:master

12 checks passed

Collaborator

Finished benchmarking commit (d0ee190): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 648.751s -> 650.258s (0.23%)

deleted the fix/issue-112439 branch

June 11, 2023 07:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

petrochenkov left review comments

Labels

merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

Development

Successfully merging this pull request may close these issues.

"Did you mean" for attributes should be the same style as functions

5 participants

</div

Recommend

About Joyk

Aggregate valuable and interesting links.
Joyk means Joy of geeK