

Implement `AsHandle`/`AsSocket` for `Arc`/`Rc`/`Box` on Windows by sunfishcode ·...
source link: https://github.com/rust-lang/rust/pull/108196
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation
added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label
Collaborator
added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label
Collaborator
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Member
Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it.
labels
added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it.
labels
added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised.
and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
labels
added finished-final-comment-period The final comment period is finished for this PR / Issue.
to-announce Announce this issue on triage meeting
and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised.
labels
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
Member
added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label
Contributor
Collaborator
Finished benchmarking commit (a14d696): comparison URL. Overall result:
|
mean | range | count | |
---|---|---|---|
Regressions ![]() (primary) |
0.5% | [0.5%, 0.5%] | 1 |
Regressions ![]() (secondary) |
- | - | 0 |
Improvements ![]() (primary) |
- | - | 0 |
Improvements ![]() (secondary) |
- | - | 0 |
All ![]() ![]() |
0.5% | [0.5%, 0.5%] | 1 |
Max RSS (memory usage)
Results
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 642.75s -> 642.634s (-0.02%)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting
None yet
Successfully merging this pull request may close these issues.
None yet
</div
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK