8

Implement `AsHandle`/`AsSocket` for `Arc`/`Rc`/`Box` on Windows by sunfishcode ·...

 2 years ago
source link: https://github.com/rust-lang/rust/pull/108196
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Member

Implement the Windows counterpart to #97437 and #107317: Implement AsHandle and AsSocket for Arc<T>, Rc<T>, and Box<T>.

yerke and chloekek reacted with hooray emoji yerke reacted with rocket emoji

sunfishcode

added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label

Feb 17, 2023

Collaborator

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label

Feb 17, 2023

Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

Member

@rustbot label +T-libs-api -T-libs
r? libs-api

Member

This seems like the logical follow up to #97437 and #107317, but since this does affect the public API:

@rfcbot merge

rfcbot

commented

May 1, 2023

edited by BurntSushi

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot

added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it.

labels

May 1, 2023

m-ou-se

added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it.

labels

May 1, 2023

rfcbot

added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised.

and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.

labels

May 4, 2023

bell This is now entering its final comment period, as per the review above. bell

rfcbot

added finished-final-comment-period The final comment period is finished for this PR / Issue.

to-announce Announce this issue on triage meeting

and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised.

labels

May 14, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

Member

@bors r+

Contributor

pushpin Commit a117c50 has been approved by dtolnay

It is now in the queue for this repository.

bors

added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label

May 14, 2023

Contributor

hourglass Testing commit a117c50 with merge a14d696...

Contributor

sunny Test successful - checks-actions
Approved by: dtolnay
Pushing a14d696 to master...

bors

added the merged-by-bors This PR was explicitly merged by bors label

May 15, 2023

bors

merged commit a14d696 into

rust-lang:master

May 15, 2023

12 checks passed

Collaborator

Finished benchmarking commit (a14d696): comparison URL.

Overall result: x regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions x
(primary)
0.5% [0.5%, 0.5%] 1
Regressions x
(secondary)
- - 0
Improvements white_check_mark
(primary)
- - 0
Improvements white_check_mark
(secondary)
- - 0
All xwhite_check_mark (primary) 0.5% [0.5%, 0.5%] 1

Max RSS (memory usage)

Results

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 642.75s -> 642.634s (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dtolnay

dtolnay approved these changes

Assignees

dtolnay

Labels

finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Projects

None yet

Milestone

1.71.0

Development

Successfully merging this pull request may close these issues.

None yet

8 participants

</div


About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK