Keep encoding attributes for closures by oli-obk · Pull Request #111381 · rust-l...
source link: https://github.com/rust-lang/rust/pull/111381
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Keep encoding attributes for closures #111381
Conversation
Contributor
see model-checking/kani#2406 (comment) for some context.
We stopped encoding attributes for closures, but some tools need them
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Contributor
Author
This comment has been minimized.
added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Trying commit Contributor
|
|
Try build successful - This comment has been minimized.
Collaborator
|
Finished benchmarking commit (4a8c1cb): comparison URL. Overall result:
|
| mean | range | count | |
|---|---|---|---|
Regressions  (primary) |
- | - | 0 |
| Regressions (secondary) |
- | - | 0 |
Improvements  (primary) |
- | - | 0 |
| Improvements (secondary) |
-0.3% | [-0.3%, -0.2%] | 2 |
| All (primary) |
- | - | 0 |
Max RSS (memory usage)
Results
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 656.874s -> 655.684s (-0.18%)
removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label
Contributor
Author
Contributor
|
@bors r+ rollup |
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
None yet
Recommend
-
10
Collaborator rust-log-analyzer commented
-
8
New issue Check callee ABI when Miri calls closures #1743
-
7
Copy link Member wesleywiser commen...
-
7
New issue Don't emit too_many_lines for closures #7534
-
7
Support `#[track_caller]` on closures and generators by Aaron1011 · Pull Request #87064 · rust-lang/rust · GitHub Copy link Member ...
-
5
Conversation Copy link Contributor ...
-
10
Copy link Collaborator rust-timer com...
-
3
New issue Check for loops/closures in local_used_after_expr #8676
-
9
Conversation Member
-
6
Conversation Contributor
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK