Delay a good path bug on drop for `TypeErrCtxt` (instead of a regular delayed bu...
source link: https://github.com/rust-lang/rust/pull/110476
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Member
r? @lcnr
Perhaps we should just delete the Drop impl altogether though?
Fixes rust-lang/rust-clippy#10645
@matthiaskrgr: I don't know how to make a clippy test for this. Any idea? Clippy's UI tests run with -D warnings and I have no idea how to switch it off to make a test that triggers this ICE in the clippy test suite 
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
Member
|
Does it work if you explicitly Need to check after work. |
Member
Author
|
No, I tried a bunch of combinations and they all seem to not work lol... |
|
r=me with or without a clippy test |
don't have an opinion on whether we should instead completely remove the Member
|
oh I see, so the ice happens AFTER the lint is emitted, and since we default to errors, compilation just stops and we simply don't hit the ICE in the tests, weird :/ |
Member
|
ok it's a bit dirty but you force the test to warn via |
Member
|
If you cherry-pick matthiaskrgr@b1d6e8f into your branch it should work I think :) |
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Member
Author
|
Thanks @matthiaskrgr for the test! @bors r=lcnr |
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
ICE: delay_span_bug: used a TypeErrCtxt without failing compilation: future-not-send`
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK