The "Learn more" text of moz-support-link should not break across line...
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1818513
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
The "Learn more" text of moz-support-link should not break across lines
Categories
(Toolkit :: XUL Widgets, enhancement, P3)
Tracking
(bug RESOLVED as FIXED)
113 Branch
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: tgiles, Assigned: imlata1111, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [fidefe-reusable-components-ms3] [lang=css])
The design recommendation is to prevent the "Learn more" text from splitting across two lines. We can accomplish this by using the display:inline-block rule on the a[is='moz-support-link'] selector in preferences.css.
Hi, I would like to help fix this bug
Hey, can I please be assigned to this issue? I already have firefox up and running on my local machine and would love to work on this issue as my first. Thank you.
(In reply to franklyn from comment #1)
Hi, I would like to help fix this bug
(In reply to Siya from comment #2)
Hey, can I please be assigned to this issue? I already have firefox up and running on my local machine and would love to work on this issue as my first. Thank you.
Needinfo'ing Tim :)
Btw, you might want to bring in :flod to verify that the proposed change is okay for all locales. I imagine it could be disadvantage when "Learn more" translates to a much longer string, or when it's even just a longer string to begin with such as "Learn more about [whatever]."
Can I work on this issue?
My setup is also ready, Please let me know if I can make a contribution.
Thanks for the reminder Dao, appreciate it!
:flod, do you foresee any issues with forcing the "Learn more" text of these new moz-support-link to potentially be on new lines in other locales? Attached is a screenshot showing one of these "Learn more" links with some modified text that moves the entire link to a new link. If the text was just "Learn more", then it would stay next to the rest of the text on the same line.
(In reply to Tim Giles [:tgiles] from comment #6)
:flod, do you foresee any issues with forcing the "Learn more" text of these new moz-support-link to potentially be on new lines in other locales? Attached is a screenshot showing one of these "Learn more" links with some modified text that moves the entire link to a new link. If the text was just "Learn more", then it would stay next to the rest of the text on the same line.
I don't think that should be problematic.
The existing translations for the stand-alone "Learn more" in mozSupportLink seem to be relatively short
https://transvision.flod.org/string/?entity=browser/browser/components/mozSupportLink.ftl:moz-support-link-text&repo=gecko_strings
hey Tim! Can I work on this bug? I am not actively working on any other bug right now. Can you assign me this? Otherwise, if there are any open bugs that need attention, I would be happy to take a look and see if I can help.
pratikaswani9333, are you still looking for a bug to work on? If so, you could pick this one up as it's been a few weeks since assigning this bug.
Lata, I'm going to see if pratikaswani9333 wishes to work on this first to give them an opportunity to contribute. If they do not wish to work on this, then I'll assign it to you.
 |
Assignee | |
Comment 10•25 days ago
|
||
Hey Tim! Since we didn't heard anything from pratikaswani9333. Can I work on this now?
Sure, Lata. Feel free to needinfo me if you need clarification, thanks.
|
Assignee | |
Comment 12•25 days ago
|
||
Hey Tim! I was looking into the bug. As you explained, it seems like to prevent the "Learn more" text from splitting across two lines we can add this line of code
a[is='moz-support-link'] {
display: inline-block;
}
should be added in preferences.css. Will this be enough to solve this issue or there is something more to be taken care of? How can I locally test it to make sure it behave expected?
Hey Lata, you can test this by going to about:preferences#privacy and modifying the "Learn more" text under "Enhanced Tracking Protection" with the devtools inspector. After modifying this string to be a bit longer, say something like "Learn more about Enhanced Tracking Protection" or any other filler you wish to use, you can resize the browser and verify the "Learn more about Enhanced Tracking Protection" doesn't jump up to the rest of the text in that section.
|
Assignee | |
Comment 15•25 days ago
|
||
Thank you Tim! I have checked in my local set up. I could see the differences before and after making the changes. However, if it require any changes further let me know.
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/40c64069c3cf The Learn more text of moz-support-link should not break across lines. r=tgiles,settings-reviewers,mconley
Recommend
-
16
Skin break out Scar Laser Treatment – Learn About the Different Types ...
-
12
So, You Want to Learn to Break Ciphers – Little Man In My HeadEvery now and then, I read a question about learning how to break ciphers, or more generally how to become a cryptographer/cryptologist. From my viewpoint, the most important part...
-
4
TL;DRVim doesn’t have to be an obscure, elitist text editor;It’s got plenty of features that can speed up your coding;Most modern IDEs and code editors have decent Vim integrations;This post intends to show you the ropes and convince yo...
-
6
Labnan Posted on Nov 21
-
10
Learn Something Old Every Day, Part IV: Ctrl+Scroll Lock is Ctrl+Break The other day I tried running NSNIPES, a multiplayer networked game that...
-
8
Don’t miss what’s happeningPeople on Twitter are the first to know....
-
6
LEARN - JavaScript Applications with Microsoft Graph (2 Part Series) ...
-
8
Details (Keywords: good-first-bug, Whiteboard: [fidefe-reusa...
-
7
Deeply ingrained in the hiring practices of too much tech companies lies the basic assumption that developers, and especially junior developers, are incompetent liars until proven otherwise. Where does that bad reputation come? ...
-
4
Closed Bug 1844288...
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK