Almost no contrast in Alpenglow findbar input
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1707005
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Almost no contrast in Alpenglow findbar input
Categories
(Firefox :: Theme, defect, P3)
Tracking
(bug RESOLVED as FIXED)
114 Branch
People
(Reporter: bugzilla, Assigned: itiel_yn8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-infobars])
The unfocused findbar textbox has almost no contrast in both Alpenglow Dark and Alpenglow Light. Screenshots attached.
Did this regress due to Proton? My understanding is that Alpenglow improvements weren't in scope for MR1
Yes, it's a Proton regression. Here's the findbar on Release 88 Alpenglow Light.
I feel like mentioning that if we are to ignore the background color of the input box versus the background color of the Findbar (color contrast issue), a separator line is observed around the Input box and next/previous buttons in Dark Theme, but not in the Light or Alpenglow Themes.
Hi guys,
Please let me know what you think about this approach.
In the WIP patch I've made the find bar to look and feel the exact same as the toolbar, so this fixes the issue at hand almost for all themes (there are themes in which the urlbar has the same issue, so this is kinda the theme author's fault and thus not a part of this patch).
As for themes with lwtheme-image
, I've made it so that the findbar will be sort of an "extension" of the toolbar/toolbox above, so only the bottom part of the image would be shown in there. See attached screenshots with several themes I've tested this with. Light and Dark themes are unaffected for the most part (hover states were changed to be like the toolbar's).
I've also made some general improvements to match the hover states, text-shadow, colors etc of the toolbox.
From my testings this works well on Light, Dark, themes, pure HCM and HCM with themes.
The patch was made specifically for Windows and so may not work well (at this time) on other platforms. I'd like to get your opinions on this before I proceed to made the needed adjustments and clean up the patch.
Thanks!
I think that looks quite good! I'm curious what others think. If we can get a consensus among engineers that this is generally a good change, we can run it by UX.
Agreed, I think this looks better. Just a note we landed Bug 1724194 this week, so should apply the same rules to findbar-close-container
as we do the findbar.
I applied the patch, looks good to me.
Reviewed by UX. Looks good.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK