Move _extensionID and _locale out of SearchEngine and into AddonSearchEngine
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1810852
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Move _extensionID and _locale out of SearchEngine and into AddonSearchEngine
Categories
(Firefox :: Search, task, P3)
Tracking
(bug RESOLVED as FIXED)
114 Branch
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: standard8, Assigned: victoria.o.ajala, Mentored)
Details
(Whiteboard: [lang=js])
We still have _extensionID references in SearchEngine, we should investigate moving them out to AddonSearchEngine, since they are only really relevant there.
There's also _locale that we should move as well.
I believe the work here is possible, bug 1819102 is something similar that was done for a few OpenSearchEngine fields. Use searchfox to find the class definitions/look at the source.
Hi @Mark Banner, I would like to work on this bug, I'm currently going through the comments and the similar bug you included in [comment 3] to understand how to go about it. I've used searchfox to find the specific files that need fixing. I assume the fix should be moving _extensionID references in toolkit/components/search/SearchEngine.sys.mjs to toolkit/components/search/AddonSearchEngine.sys.mjs as well as _locale.
(In reply to Victoria Ajala from comment #3)
Hi @Mark Banner, I would like to work on this bug, I'm currently going through the comments and the similar bug you included in
[comment 3]to understand how to go about it. I've used searchfox to find the specific files that need fixing. I assume the fix should be moving_extensionIDreferences intoolkit/components/search/SearchEngine.sys.mjstotoolkit/components/search/AddonSearchEngine.sys.mjsas well as_locale.
Generally yes, but where's there are functions (e.g. this one) in SearchEngine that use _extensionID, we'll need to keep those returning an appropriate value, and override the function in AddonSearchEngine.
(In reply to Mark Banner (:standard8) from comment #4)
Generally yes, but where's there are functions (e.g. this one) in
SearchEnginethat use_extensionID, we'll need to keep those returning an appropriate value, and override the function inAddonSearchEngine.
I've created a patch for this but I've only removed the _extensionID function in the SearchEngine. I'm unsure where and how to override the function in AddonSearchEngine.
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/c8fc4588a1c6 Moved _extensionID and _locale functions out of SearchEngine and into AddonSearchEngine. r=Standard8
Recommend
-
44
I am trying to install package and doing some other work. But, getting the error that read as “ perl: warning: Setting loc...
-
11
Currency internationalizationApril 22, 2020 · 2 min readMaksim SharipovMaintainer of eo-locale
-
11
PHP RFC: Locale-independent float to string cast Version: 1.0 Date: 2020-03-11
-
10
Open Bug 331779 Opened 15 years ago Updated 2 years ago
-
5
ubuntu 下设置 locale 报错 $ /usr/bin/locale: Cannot set LC_CTYPE to default locale: No such file or directory $ /usr/b...
-
261
warning: setlocale: LC_CTYPE: cannot change locale (UTF-8): No such file or directory ...
-
12
解决 Arch Linux（KDE Plasma）中 Locale LANG=C 的问题 2021-10-08 约 243 字 预计阅读 1 分钟 3 次阅读 最近在 Arch Linux 上的 Git 显示不了中文，执行了
-
7
How to Set Locale and Add-Type in Krayin? You can change language and time zone from the Krayin CRM configuration setting. Here I wil...
-
5
Changing the Locale in Chrome with Dev Tools Mar 09, 2022 When working on internationalized apps, it's important to test different locales to ensure that the design looks acceptable for a wide range...
-
5
This post is part of my Byte Series, where I document tips, tricks, and tools that I've found useful.ProblemWhen building a localized JavaScript web-app, the default so...
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK