Correct branch-protection ModFlagBehavior for Aarch64 on LLVM-15 by MasterAwesom...
source link: https://github.com/rust-lang/rust/pull/105932
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
When building with Fat LTO and BTI enabled on aarch64, the BTI is set to Module::Min for alloc shim but is set to Module::Error for the crate. This was fine when we were using LLVM-14 but LLVM-15 changes it's behaviour to support for compiling with different mbranch-protection flags.
Refer:
rust-lang/llvm-project@b0343a3
fixes #102162
Collaborator
rustbot commented Dec 20, 2022
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
changed the title
Correct ModFlagBehavior for Aarch64 on LLVM-15
Correct branch-protection ModFlagBehavior for Aarch64 on LLVM-15
This comment has been minimized.
Contributor
nikic commented Dec 20, 2022
|
Min is new in LLVM 15, so this will have to be dependent on version. Either need to pass in Min/Error depending on version, or possibly adjust to automatically use Error instead of Min for old versions. |
|
Ah I see, I'll do an FFI call prior to setting the modflagbehavior to get the version and choose I could add that in the cpp file but I think it might hide future hard to debug issues where the What do you think? |
Contributor
nikic commented Dec 20, 2022
|
Either way is fine by me. On the Rust side, there's already a |
Contributor
nikic commented Dec 21, 2022
|
@bors r+ |
Contributor
bors commented Dec 21, 2022
Commit added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
None yet
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK