4

Add command for manually running flychecks by Veykril · Pull Request #13785 · ru...

 1 year ago
source link: https://github.com/rust-lang/rust-analyzer/pull/13785
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Add command for manually running flychecks #13785

Conversation

Member

@Veykril Veykril commented Dec 16, 2022

Closes #13125

rustbot

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label

Dec 16, 2022

Member

Author

Veykril commented Dec 16, 2022

@bors r+

Collaborator

bors commented Dec 16, 2022

pushpin Commit a04feb9 has been approved by Veykril

It is now in the queue for this repository.

Collaborator

bors commented Dec 16, 2022

hourglass Testing commit a04feb9 with merge e0aa5af...

Collaborator

bors commented Dec 16, 2022

sunny Test successful - checks-actions
Approved by: Veykril
Pushing e0aa5af to master...

Member

flodiebold commented Dec 19, 2022 •

edited

We should probably not call it "Flycheck" for the user, how about just Run check?

Veykril

deleted the run-flycheck branch

Dec 19, 2022

Member

Author

Veykril commented Dec 19, 2022 •

edited

I agree that flycheck isn't the best fit, but check seems really generic so I am not sure if its apparent what check necessarily means for people when they read it for the first time either? I guess Run cargo check would be better? (shame we can't have the command label be dynamic).

Alternatively we can start pushing the flycheck term so that people know what it means. After adding this I was thinking of maybe changing the name of checkOnSave configs to check, flycheck, etc since it's no longer only tied to saving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: Command to run check/clippy without saving

4 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK