8

Correctly resolve Inherent Associated Types by fee1-dead · Pull Request #103621...

 2 years ago
source link: https://github.com/rust-lang/rust/pull/103621
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Conversation

Member

@fee1-dead fee1-dead commented Oct 27, 2022 •

edited

I don't know if this is the best way to do this, but at least it is one way.

compiler-errors reacted with thumbs up emojifmease, PatchMixolydic, and WaffleLapkin reacted with eyes emoji All reactions

Collaborator

rustbot commented Oct 27, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Oct 27, 2022

This comment has been minimized.

This comment has been minimized.

Member

wesleywiser commented Oct 31, 2022

I don't think I have enough context to do give a good review here.

r? @cjgillot

Feel free to reroll if you didn't want to take over the review slightly_smiling_face

Contributor

cjgillot commented Nov 3, 2022

@bors r+

Contributor

bors commented Nov 3, 2022

pushpin Commit 3aef6c6 has been approved by cjgillot

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 3, 2022

Member

BoxyUwU commented Nov 4, 2022

I am not sure this is what we want, it seems like closer to what we want is for assoc types to stay unresolved into typeck so that for example: <_>::Assoc can work thinking Probably fine to land this so the feature is Useable Now but it would be good to record this somewhere so it doesnt get forgotten before stabilization.
fee1-dead reacted with thumbs up emoji All reactions

bors

merged commit 3450aa3 into

rust-lang:master

Nov 5, 2022

10 checks passed

rustbot

added this to the 1.67.0 milestone

Nov 5, 2022

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Nov 5, 2022

fee1-dead

deleted the iat-fix-use branch

Nov 5, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjgillot

Assignees

cjgillot

Labels
F-inherent_associated_types `#![feature(inherent_associated_types)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.67.0

Development

Successfully merging this pull request may close these issues.

None yet

7 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK