fix: correct broken logic for return complition by matklad · Pull Request #13187...
source link: https://github.com/rust-lang/rust-analyzer/pull/13187
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
fix: correct broken logic for return complition #13187
Merged
Conversation
Member
matklad
commented
4 days ago
It seems that we've accidentally deleted the tests here couple of years
ago, and then fairly recently made a typo during refactor as well.
Reinstall tests, with coverage marks this time :-)
|
I take full responsibility (I am 99% certain this was me, given how much I touched completions the past months |
)Collaborator
bors commented 4 days ago
Commit Collaborator
bors commented 4 days ago
Testing commit Collaborator
bors commented 4 days ago
|
|
Test successful - Member
Author
matklad commented 4 days ago
|
You indeed broke completions, but it was me who approved the PR nuking the tests :-) And tests are more important than code |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No reviews
No one assigned
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK