5

Allow `#[ignore]` tests to run in rustfmt's test suite by ytmimi · Pull Request...

 1 year ago
source link: https://github.com/rust-lang/rustfmt/pull/5397
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Contributor

@ytmimi ytmimi commented 16 days ago

There are some tests in the rustfmt test suite that are ignored by default. I believe these tests are ignored because they have caused issues with the the rust-lang/rust test suite.

However, we recently experienced an issue (#5395) that would have been avoided had these tests been running.

With the introduction of the new #[rustfmt_only_ci_test] attribute macro we can run these tests when the RUSTFMT_CI environment variable is set, which will presumably only be set during rustfmts CI runs. When the environment variable is not set the #[rustfmt_only_ci_test] will be replaced with an #[ignore].

All reactions

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK