6

Enable using Fathom to recognize credit card number field

 1 year ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1759418
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Enable using Fathom to recognize credit card number field

Assignee: nobody → dlee
Attachment #9277275 - Attachment description: WIP: Bug 1759418 - P1. Update CreditCardRuleset.jsm to → Bug 1759418 - P1. Update CreditCardRuleset.jsm to r=sgalich!
Status: NEW → ASSIGNED
Attachment #9277276 - Attachment description: WIP: Bug 1759418 - P2. Use Fathom to detect cc-number field → Bug 1759418 - P2. Use Fathom to detect cc-number field r=sgalich!
Attachment #9277277 - Attachment description: WIP: Bug 1759418 - P3. Enable using Fathom to recognize CC field → Bug 1759418 - P3. Enable using Fathom to recognize CC field r=sgalich!
Attachment #9277275 - Attachment description: Bug 1759418 - P1. Update CreditCardRuleset.jsm to r=sgalich! → Bug 1759418 - P1. Update CreditCardRuleset.jsm to e6aff61 r=sgalich!

Backed out for causing bp-hybrid bustages on FormAutofillNative.

Push with failures

Failure log

Backout link

[task 2022-05-23T21:57:24.866Z] 21:57:24     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/toolkit/components/formautofill'
[task 2022-05-23T21:57:24.869Z] 21:57:24     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -Xclang -std=c++17 -FoFormAutofillNative.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DOS_WIN=1 -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DCOMPILER_MSVC -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/toolkit/components/formautofill -I/builds/worker/workspace/obj-build/toolkit/components/formautofill -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -FI /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -Qunused-arguments -W3 -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wthread-safety -fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -Gy -Zc:inline -Gw -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Werror -fno-strict-aliasing -Xclang -ffp-contract=off  -Xclang -MP -Xclang -dependency-file -Xclang .deps/FormAutofillNative.obj.pp -Xclang -MT -Xclang FormAutofillNative.obj   /builds/worker/checkouts/gecko/toolkit/components/formautofill/FormAutofillNative.cpp
[task 2022-05-23T21:57:24.870Z] 21:57:24     INFO -  /builds/worker/checkouts/gecko/toolkit/components/formautofill/FormAutofillNative.cpp(351,17): error: unused variable 'kCCNameBias' [-Werror,-Wunused-const-variable]
[task 2022-05-23T21:57:24.870Z] 21:57:24     INFO -  constexpr float kCCNameBias = -5.3578081130981445;
[task 2022-05-23T21:57:24.871Z] 21:57:24     INFO -                  ^
[task 2022-05-23T21:57:24.871Z] 21:57:24     INFO -  /builds/worker/checkouts/gecko/toolkit/components/formautofill/FormAutofillNative.cpp(352,17): error: unused variable 'kCCTypeBias' [-Werror,-Wunused-const-variable]
[task 2022-05-23T21:57:24.872Z] 21:57:24     INFO -  constexpr float kCCTypeBias = -5.979659557342529;
[task 2022-05-23T21:57:24.872Z] 21:57:24     INFO -                  ^
[task 2022-05-23T21:57:24.872Z] 21:57:24     INFO -  /builds/worker/checkouts/gecko/toolkit/components/formautofill/FormAutofillNative.cpp(353,17): error: unused variable 'kCCExpBias' [-Werror,-Wunused-const-variable]
[task 2022-05-23T21:57:24.873Z] 21:57:24     INFO -  constexpr float kCCExpBias = -5.849575996398926;
[task 2022-05-23T21:57:24.873Z] 21:57:24     INFO -                  ^
[task 2022-05-23T21:57:24.873Z] 21:57:24     INFO -  /builds/worker/checkouts/gecko/toolkit/components/formautofill/FormAutofillNative.cpp(354,17): error: unused variable 'kCCExpMonthBias' [-Werror,-Wunused-const-variable]
[task 2022-05-23T21:57:24.873Z] 21:57:24     INFO -  constexpr float kCCExpMonthBias = -8.844199180603027;
[task 2022-05-23T21:57:24.875Z] 21:57:24     INFO -                  ^
[task 2022-05-23T21:57:24.878Z] 21:57:24     INFO -  /builds/worker/checkouts/gecko/toolkit/components/formautofill/FormAutofillNative.cpp(355,17): error: unused variable 'kCCExpYearBias' [-Werror,-Wunused-const-variable]
[task 2022-05-23T21:57:24.878Z] 21:57:24     INFO -  constexpr float kCCExpYearBias = -6.499860763549805;
[task 2022-05-23T21:57:24.879Z] 21:57:24     INFO -                  ^
[task 2022-05-23T21:57:24.879Z] 21:57:24     INFO -  5 errors generated.
[task 2022-05-23T21:57:24.879Z] 21:57:24    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:660: FormAutofillNative.obj] Error 1
[task 2022-05-23T21:57:24.879Z] 21:57:24     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/components/formautofill'
[task 2022-05-23T21:57:24.882Z] 21:57:24    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: toolkit/components/formautofill/target-objects] Error 2
[task 2022-05-23T21:57:24.882Z] 21:57:24     INFO -  gmake[3]: *** Waiting for unfinished jobs....
[task 2022-05-23T21:57:24.882Z] 21:57:24     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/threads'

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK