6

Use the finalized query parameter when excluding AMP URLs from appearing as tile...

 2 years ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1768533
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client
Closed Bug 1768533 Opened 25 days ago Closed 16 days ago

Use the finalized query parameter when excluding AMP URLs from appearing as tiles on the new tab page

Categories

(Firefox :: New Tab Page, task, P1)

Tracking

(bug has been fixed and VERIFIED which is tracked for Firefox 101)

VERIFIED FIXED

102 Branch

Tracking Status
firefox101 + verified
firefox102 --- verified

People

(Reporter: adw, Assigned: adw)

References

Details

We need to make sure we use the finalized query parameter when excluding AMP URLs from the new tab page. If the parameter is finalized before bug 1768529 lands, then we can do this as part of that bug and close this one without any further work required. If the parameter is not finalized before then, we'll need to land a small follow-up patch as part of this bug that uses the finalized parameter.

Pushed by [email protected]:
https://hg.mozilla.org/integration/autoland/rev/101e92fc97d5
Use the finalized query parameter when excluding AMP URLs from appearing as tiles on the new tab page. r=nanj
Status: ASSIGNED → RESOLVED
Closed: 16 days ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch

STR are similar to bug 1768529 comment 3 except we only need to verify one case.

  1. Type example.com/?mfadid=adm in the urlbar and press enter
  2. Repeat the previous step 2 more times. You can use the same tab.
  3. Restart Firefox
  4. Verify "example" does not appear as a top sites tile on the new tab page
  5. Type example.com (without anything else at the end) in the urlbar and press enter
  6. Type https://www.mozilla.org/ in the urlbar and press enter. You can use the same tab.
  7. Restart Firefox
  8. Verify "mozilla" and "example" appear as top sites tiles on the new tab page
  9. Click the "example" tile
  10. Verify example.com (without anything else at the end) loads
Flags: qe-verify+
Flags: in-testsuite-

I‘ve verified this task using the latest Firefox Nightly 102.0a1 (Build ID: 20220518214245) on Windows 10 x64, macOS 12.3.1, and Ubuntu 20.04 x64.

  • After navigating to the “example.com/?mfadid=adm” page several times, the "example" does not appear as a top sites tile on the new tab page.
  • The "mozilla" and "example" appear as top sites tiles on the new tab page after navigating to the “example.com” and “https://www.mozilla.org/” pages. Also, the “example.com” page loads after clicking the “example” top site tile.
Status: RESOLVED → VERIFIED
Flags: qe-verify+

[Tracking Requested - why for this release]: This patch implements a feature request for our tiles partner, and we'd like it to be released in Fx 101 if possible.

Comment on attachment 9277004 [details]
Bug 1768533 - Use the finalized query parameter when excluding AMP URLs from appearing as tiles on the new tab page.

Beta/Release Uplift Approval Request

  • User impact if declined: There is little impact on Firefox users, rather it's a feature request from our partner of sponsored tiles. If declined, Firefox would show previous sponsored tiles as organic tiles which could de-value the sponsored tiles for both our partner and Mozilla.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1768529
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not a user-facing change, it only changes how previous sponsored tiles will be treated for Top Sites on the newtab page.
  • String changes made/needed: None
  • Is Android affected?: No
Attachment #9277004 - Flags: approval-mozilla-beta?

Comment on attachment 9277004 [details]
Bug 1768533 - Use the finalized query parameter when excluding AMP URLs from appearing as tiles on the new tab page.

Approved for 101.0rc2.

Attachment #9277004 - Flags: approval-mozilla-beta? → approval-mozilla-release+

We have verified this issue on Firefox 101.0 RC2 build (Build ID: 20220525210143) downloaded from treeherder on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04.

  • In order to verify this issue we have used the STR described in comment 4. During testing, we haven't found any new issues.
You need to log in before you can comment on or make changes to this bug.

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK