ZmisiS said:

I rooted today my Samsung Galaxy S10 (SM-G973F) with Magisk. Android 12 HVC6. Everything was fine until I'm a Reboot system. After that, the system was booted, but it is not more a rooted.

Can I return root? If yes, how?

How did you root?
If you installed Magisk in the recovery partition, you might just need to reboot the right way: hold buttons to boot to recovery, but release buttons before you get to recovery. (I think I've also seen posts about skipping the fussing with buttons by using a cable and ADB on a PC.)

J.Michael said:

How did you root?
If you installed Magisk in the recovery partition, you might just need to reboot the right way: hold buttons to boot to recovery, but release buttons before you get to recovery. (I think I've also seen posts about skipping the fussing with buttons by using a cable and ADB on a PC.)

I patched AP with Magisk. Patched AP with ADB copied on my PC. Install with Odin. All is was fine. System is was rooted. After reboot system, root is lost.

Problem solved. In adb I used 'adb reboot recovery' > Enter, after reboot system, system is rooted.

For reboot now I use Root Essentials app.

OsoAlgo said:

I have experienced a weird problem when changing SIM cards, maybe someone here can help me. I am currently running stock-rooted Android 11 on Galaxy S10e with Magisk and TWRP. This works without issues and, if I need to reboot, I usually open Magisk and click on 'Reboot to recovery' there, so I don't need to press a key combo nor have a USB cable plugged in in that case.

However, if I try to change my SIM card (even while the phone is off), as soon as the phone detects this, I get an uncloseable pop-up saying that the SIM changed and I need to reboot (note that I have SIMs from different countries). If I click OK in the pop-up, the phone reboots to the partition without root, and I can't avoid it. I tried pressing the key combo, but that didn't work. I also tried plugging the phone to my PC before the pop-up appeared and, after the pop-up, issuing an 'adb reboot recovery' command, but that didn't help either, after a successful reboot, the pop-up appeared again.

Most puzzling to me is that, if I give in and press OK in the pop-up, it completely messes up my setup, almost as if the recovery partition is reverted to stock; I can't boot to my rooted partition anymore, not with the key combo, not with adb, not with anything. In my attempts, I always have to boot to download mode and flash everything again through Odin with the new SIM inserted.

Has anyone else had this issue and found a way to work around it?

Click to expand...

I do not have this device. Is it A/B or A-only?

If you do not change the SIM card, and you shut down, and then reboot -- just holding Power button until it reacts, then just waiting as long as necessary, no more button dancing -- does it boot with Magisk active?

Does it behave any differently if you delete all accounts (are there accounts other than Google accounts?) before shut down and change SIM?
(There is a warning to delete Google account from tablet before running Odin. I wondered if there was also some interaction with a SIM card.)

J.Michael said:

I do not have this device. Is it A/B or A-only?

If you do not change the SIM card, and you shut down, and then reboot -- just holding Power button until it reacts, then just waiting as long as necessary, no more button dancing -- does it boot with Magisk active?

Does it behave any differently if you delete all accounts (are there accounts other than Google accounts?) before shut down and change SIM?
(There is a warning to delete Google account from tablet before running Odin. I wondered if there was also some interaction with a SIM card.)

It's A-only. If I boot without pressing any key combo, it boots without root/Magisk. I've never tried deleting all accounts beforehand, I guess I could try that next time if there are no other options...

topjohnwu said:

Here comes official Magisk support for the Galaxy S10!
Let's get Magisk to kick start the development of these Samsung devices!
is enabled.

Natraj said:

Thanks for creating the samsung-system-as-root page . I had some difficulties with the patched AP file though. Something went wrong during the flashing process and I had to reset the stock Android ROM. Then I wanted to try again flashing the already patched AP file, but that didn't work. It got stuck in the Odin "cache" phase. However, when I patched again the AP file with the Magisk app, then then flashing worked fine.
I.e. I belive that a patched AP file can't be reused after a ROM wipe. The AP file has to be patched again after reset and only then flash.
Would you agree that this is correct?
If yes, it might be worth mentioning it in the instruction page. It took me a while to figure the out.

What you describe is a problem using a "previously patched AP" which had never worked for you. Maybe there was a problem copying the original file to the device, or copying the patched file back to the PC.
Did you check at both stages? (I run "md5sum" at both ends. I've never seen a mismatch, but I keep reading dire warnings.)

If you successfully install a patched AP (along with BL, CP, [HOME_]CSC), I think you can count on being successful at a later date using exactly the same files. But it has to be exactly the same files.

Natraj said:

@J.Michael I know that it has worked before, but something didn't work as expected and I had to reset Android. That's why I know it has worked before and also I didn't copy it from one place to another. It was on an external USD-HDD and I used it both times to flash the image. I didn't do the MD5 check, but since it did work the first time, I suppose it should also work the second time from the same USB-HDD.
Either way, maybe there was something else if you say it should still work even after a device reset.

The MD5 check is just my way of confirming the integrity of a copy -- people say don't use Windows Explorer, or maybe it's don't use MTP file transfer, use ADB PUSH/PULL; it's easier for me to use Windows Explorer and then run md5sum on both ends.

You say you "know it has worked before". That was not the impression I got from reading your description. I thought you said you patched AP, tried to flash patched AP, failed to flash, reset device, tried again to flash without repatching AP, failed; then repatched AP and flashed successfully.

Maybe Magisk does not have proper access to the external drive, or something does not flush properly. You could try repeatedly patching on the external drive, comparing the result against the good patched AP. If the problem is that one time you disconnected the external drive before it was finished writing, you probably won't reproduce that particular error.

Is there something in Android like Windows' "eject drive" to make sure all buffers have been flushed before disconnecting? Do you use it? Could you have forgotten once?