10

Fix unsound `File` methods by ChrisDenton · Pull Request #95469 · rust-lang/rust...

 3 years ago
source link: https://github.com/rust-lang/rust/pull/95469
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Copy link

Contributor

@ChrisDenton ChrisDenton commented 18 days ago •

edited

This is a draft attempt to fix #81357. EDIT: this PR now tackles read(), write(), read_at(), write_at() and read_buf. Still needs more testing though.

cc @jstarks, can you confirm the the Windows team is ok with the Rust stdlib using NtReadFile and NtWriteFile?

Also, I'm provisionally using CancelIo in a last ditch attempt to recover but I'm not sure that this is actually a good idea. Especially as getting into this state would be a programmer error so aborting the process is justified in any case. EDIT: removed, see comments.

pravic reacted with thumbs up emoji

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK