13

Github update to latest memchr + upgrade to Rust 2018 + bump MSRV to Rust 1.41 b...

 3 years ago
source link: https://github.com/rust-lang/regex/pull/767
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
neoserver,ios ssh client

Copy link

Member

BurntSushi commented 15 days ago

The main motivation for this PR is to use the new memmem implementation in memchr 2.4 (not quite released at time of writing, but in a PR). This let's us delete regex's own bespoke substring search implementations ("FreqyPacked" along with Boyer-Moore). The main benefit of the new implementation is that it should roughly maintain the speed of the old algorithms, but keep its speed in a lot more cases. i.e., It should have far fewer weaknesses. Plus, the algorithm is now available for anyone to use without bringing in regex.

While we're here, we (finally) move to Rust 2018 and bump the MSRV to Rust 1.41 (since that's what's in Debian Stable). There's no particular reason why I waited so long to do this. It was never my intent to support such an old version of Rust for so long. There was just never a strong impetus to upgrade. But with Rust 2021 around the bend, it seems appropriate to at least migrate to Rust 2018. Hopefully we'll get to Rust 2021 sooner.

(The plan is to merge this PR once I do a similar change to the aho-corasick crate.)


report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK