4

ir3/isa,parser: fix encoding and parsing of bindless s2en SAM

 3 years ago
source link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9628
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

ir3/isa,parser: fix encoding and parsing of bindless s2en SAM

Before, decoding showed that there is an error:

     sam.base0 (f32)(xyzw)r0.x, r0.z, a1.x   ; no field 'HAS_SAMP',
      WARNING: unexpected bits[0:7] in #cat5-samp-s2en-bindless-a1: 0x1 vs 0x0

After:

     sam.base0 (f32)(xyzw)r0.x, r0.z, s#1, a1.x

I don't think there is a deqp test which triggers an emission of this instruction...
The test for disasm is not from the blob.

Fixes textures on the ground in TauCeti Vulkan Technology Benchmark.

Before:

After:


report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK