freedreno: Enable GLSL 3.30, updating us to GL 3.3 contexts

freedreno: Enable GLSL 3.30, updating us to GL 3.3 contexts (!8270) · Merge Requests · Mesa

A follow up to !8255 (merged)

All necessary features are already supported.

GL33 failing tests:

I also updated features.txt for gl <= 3.3 (I didn't update features required by upper versions).

Edited 2 months ago by Danylo Piliaiev

Request to merge Danil:freedreno/enable-glsl-330 into master

Detached merge request pipeline #252105 passed for 2b29ec7c

Approval is optional

Test summary results are being parsed

The changes were merged into master with 2b29ec7c

The source branch has been deleted

Pipeline #252109 failed for 2b29ec7c on master

There will be some updating of the piglit expectations to do now that we've landed CI for it.
Collapse replies
we've landed CI for it

I updated the lists. However two changes in .gitlab-ci/piglit/freedreno-a630-gl.txt are a bit strange:

- object namespace pollution/vertex-array with glcopytexsubimage2d: skip - spec/!opengl 1.1/clear-accum: skip

Maybe they were excluded and later removed from the exclusion list, while expected results were not updated?
Also I cannot reproduce the failure of arb_draw_indirect-transform-feedback...
Yeah, I didn't keep that list updated as I extended the skips list, since it's a manual one. Expect to find remaining flakes in there, too.
So, are changes to the lists ok?
I think so. I'm more concerned about the new fails in the piglit list, but I think they're probably all tests accidentally gated on GL version rather than new functionality. I think I'm good with landing this as is, but I'd like to see some followup on those fails.
but I think they're probably all tests accidentally gated on GL version rather than new functionality

Yes, the failures don't look like a new functionality, e.g. basic-imagestore-non-const-uniform-index crashes because we don't support non-constant indexing of image arrays. I don't think this counts as "new functionality" for the intent of enabling GL33.

The only strange failure is arb_draw_indirect-transform-feedback, which passes on my board.

Please register or sign in to reply

Recommend