0
Fix debuginfo strip when using `--target` by ehuss · Pull Request #13618 · rust-...
source link: https://github.com/rust-lang/cargo/pull/13618
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
This fixes an issue where automatic strip of debuginfo added in #13257 wasn't working when the --target flag was used.
The problem is that the adjustment code was only running in the optimization pass that is done when --target is not specified.
The solution is to just always run the unit graph rebuild. I believe it should be safe to do so, since the adjustments it makes should be conditional on just the scenarios that matter when --target is not specified. The downside is that this might be a small performance hit when --target is used. Trying to avoid that I think would be quite challenging.
Fixes #13617
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK