feat: Add a basic linting system #13621

Conversation

Contributor

This PR adds a basic linting system, the first step towards User control over cargo warnings. To demonstrate the system, a lint for #12826 is added. It supports controlling cargo lints via the [lints.cargo] table. Lints can be controlled either by a group or individually.

This is meant to lay down some fundamental infrastructure for the whole linting system and is not meant to be fully featured. Over time, features will be added that will help us reach a much more solid state.

weihanglo and jeffparsons reacted with hooray emojiweihanglo and jeffparsons reacted with heart emoji

Collaborator

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added A-manifest Area: Cargo.toml issues A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

		}

		impl Lint {
		pub fn level(&self, lints: &TomlToolLints, edition: Edition) -> LintLevel {

		});
		// Add implicit features for optional dependencies if they weren't
		// explicitly listed anywhere.
		let explicitly_listed = user_defined_features.map_or(HashSet::new(), \|f\| {

		use std::path::Path;
		use toml_edit::ImDocument;

		fn get_span(document: &ImDocument<String>, path: &[&str], get_value: bool) -> Option<Range<usize>> {

		edition_lint_opts: Some((Edition::Edition2024, LintLevel::Deny)),
		};

		pub fn check_implicit_features(


		/// Gets the relative path to a manifest from the current working directory, or
		/// the absolute path of the manifest if a relative path cannot be constructed
		fn rel_cwd_manifest_path(path: &Path, gctx: &GlobalContext) -> String {

		let level = self
		.groups
		.iter()
		.map(\|g\| g.name)
		.chain(std::iter::once(self.name))
		.filter_map(\|n\| lints.get(n).map(\|l\| (n, l)))
		.max_by_key(\|(n, l)\| (l.priority(), std::cmp::Reverse(*n)));

		match level {
		Some((_, toml_lint)) => toml_lint.level().into(),
		None => {
		if let Some((lint_edition, lint_level)) = self.edition_lint_opts {
		if edition >= lint_edition {
		return lint_level;
		}
		}
		self.default_level
		}
		}
		}

		impl LintLevel {
		pub fn to_diagnostic_level(self) -> Level {
		match self {
		LintLevel::Allow => Level::Note,

		{
		continue;
		}
		if lint_level == LintLevel::Forbid \|\| lint_level == LintLevel::Deny {

		}
		let level = lint_level.to_diagnostic_level();
		let manifest_path = rel_cwd_manifest_path(path, gctx);
		let message = level.title("unused optional dependency").snippet(

		name: "rust-2024-compatibility",
		default_level: LintLevel::Allow,
		desc: "warn about compatibility with Rust 2024",
		edition_lint_opts: Some((Edition::Edition2024, LintLevel::Deny)),

		@@ -0,0 +1,34 @@
		use cargo_test_support::prelude::*;

		let path = path.join("Cargo.toml");
		if let MaybePackage::Package(pkg) = maybe_pkg {
		self.emit_lints(pkg, &path)?
		}

		if tool == "cargo" && !gctx.cli_unstable().cargo_lints {
		warn_for_cargo_lint_feature(gctx, warnings);
		}

feat: Add a basic linting system by Muscraft · Pull Request #13621 · rust-lang/c...

feat: Add a basic linting system #13621

Conversation

Recommend

About Joyk