5

Enable profiler in dist-powerpc64-linux by ecnelises · Pull Request #118100 · ru...

 5 months ago
source link: https://github.com/rust-lang/rust/pull/118100
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Enable profiler in dist-powerpc64-linux #118100

Conversation

Contributor

No description provided.

Collaborator

r? @Kobzol

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

labels

Nov 20, 2023

Contributor

Hi, could you please provide a bit of context to this PR, like why was this change made? Thanks! :)

Contributor

Author

Hi, this is from briansmith/ring#1679 . I'd like to add profiler builtin to CI build of powerpc64-linux (and powerpc-linux). Since powerpc64le-linux and other mainstream targets already have --enable-profiler in build flags, this will not bring maintainance burden I think.

I verified it from a cross build from x86_64-linux to powerpc64-linux and it generates LLVM profdata as expected.

Contributor

Oh, I see that it's indeed already enabled for le PowerPC. Then this is fine. Feel free to send another PR for powerpc if you also need it.

@bors r+ rollup

ecnelises reacted with thumbs up emoji

Contributor

📌 Commit 244e181 has been approved by Kobzol

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Nov 22, 2023

bors

merged commit 90f04e1 into

rust-lang:master

Nov 22, 2023

11 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Nov 22, 2023

Contributor

Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

No reviews

Assignees

Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK