8

Remove underscore check for `manual_non_exhaustive` lint by GuillaumeGomez · Pul...

 5 months ago
source link: https://github.com/rust-lang/rust-clippy/pull/11844
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

Member

Fixes #10550.

As indicated in #10559, the underscore check should be removed.

changelog: remove underscore check for manual_non_exhaustive lint

r? @blyxyas

rustbot

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label

Nov 20, 2023

Member

@blyxyas blyxyas

left a comment

Shouldn't this check also be removed from line 121? Or am I missing something?

Member

Author

@blyxyas told me they're busy IRL for the next weeks so I'll assign someone else to prevent taking time from them (thanks for all your reviews!).

I applied the suggestion, thanks for that!

r? @flip1995

Member

I looked for the motivation behind checking for _ prefixes, but couldn't find any comments about this when this lint was implemented.

I also ran lintcheck for this on the top 400 crates. It triggered in 2 more cases. Both were legit:

proc-macro-error-1.0.4/src/diagnostic.rs:13:1
rustls-0.22.0-alpha.4/src/versions.rs:11:1

@bors r+

Thanks!

Contributor

📌 Commit 91fc4b3 has been approved by flip1995

It is now in the queue for this repository.

Contributor

⌛ Testing commit 91fc4b3 with merge a72730e...

bors

merged commit a72730e into

rust-lang:master

Nov 22, 2023

5 checks passed

GuillaumeGomez

deleted the manual_non_exhaustive-rm-underscore-check branch

November 22, 2023 13:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Back to tour

blyxyas

blyxyas left review comments
Assignees

flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rustdoc: synthetic_non_exhaustive lint

5 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK