2

support array return types in simd_bitmask by RalfJung · Pull Request #2895 · ru...

1 year ago

source link: https://github.com/rust-lang/miri/pull/2895
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

support array return types in simd_bitmask #2895

Conversation

Member

Fixes #2734

As usual I am stomped by the simd_bitmask behavior wrt endianess. I confirmed that for little endian, Miri matches what rustc currently does, but I can't test rustc on big endian. @workingjubilee @calebzulawski could you have a look whether those new tests make sense?

changed the title ~~support array return types in simb_bitmask~~

support array return types in simd_bitmask

This looks correct--the endianness only affects each separate element and not the array order (in std::simd, we reverse each array element on big endian)

Member

Author

Ah, I didn't even realize that that is what happens -- thanks!

calebzulawski and workingjubilee reacted with thumbs up emoji

Contributor

Commit 54e1bd0 has been approved by RalfJung

It is now in the queue for this repository.

Contributor

Testing commit 54e1bd0 with merge 1a80d1e...

Contributor

Test successful - checks-actions
Approved by: RalfJung
Pushing 1a80d1e to master...

1 similar comment

merged commit 1a80d1e into

rust-lang:master

8 checks passed

deleted the simd_bitmask branch

May 17, 2023 08:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

simd_bitmask ICEs when result type is array

3 participants

Recommend

About Joyk

Aggregate valuable and interesting links.
Joyk means Joy of geeK