4

feat: add config for inserting must_use in `generate_enum_as_method` by feniljai...

 1 year ago
source link: https://github.com/rust-lang/rust-analyzer/pull/13359
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Contributor

@feniljain feniljain commented Oct 6, 2022

edited

Should fix #13312

Didn't add a test because I was not sure on how to add test for a specific configuration option, tried to look for the usages for other AssistConfig variants but couldn't find any in tests. If there is a way to test this, do point me towards it.

I tried to extract the formatting string as a common template_string and only have if-else for that, but it didn't compile :(

Also it seems these tests are failing:

test config::tests::generate_config_documentation ... FAILED
test config::tests::generate_package_json_config ... FAILED

Can you also point me to how to correct these sweat_smile ( I guess there is some command to automatically generate these? )

All reactions

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK