Remove print.tab_modal.enabled pref and old frontend print preview code
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1702501
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Remove print.tab_modal.enabled pref and old frontend print preview code
Categories
(Toolkit :: Printing, task, P3)
Tracking
(bug RESOLVED as FIXED)
97 Branch
People
(Reporter: mstriemer, Assigned: jwatt)
References
(Depends on 2 open bugs, Blocks 3 open bugs)
Details
(Whiteboard: [proton-cleanups])
Any code that references print.tab_modal.enabled
can have the check and the code related to the preffed off branch removed.
- Some of the code in PrintUtils will likely become unused.
- In PrintingChild,
Printing:Preview:Navigate
is likely the only message that will be called and the rest can be removed. - printPageSetup and printPreviewToolbar should become unused.
- printProgress is likely not used, but support for it will need to be removed from the C++ code.
- A lot of tests can be cleaned up.
Print modal is not accessible.
I know it's a migraine trigger. Bug 1692100. It has the preview scroll separate from the background.
I don't know how the capabilities compare with system print dialogues, because I can't use the modal without getting a migraine.
I don't know if it has other accessibility problems, for the same reason.
I think before we do this we should look into fixing bug 1712104 - "Implement the DisablePrintPreview policy from Chrome and Edge" first.
In looking at this more, I think it would make sense to do this and the DisablePrintPreview work at the same time.
I started looking at how do add the DisablePrintPreview policy and if I follow the same paths as the tab_modal code, we're just going to end up keeping all of the unnecessary code.
All the DisablePrintPreview code needs to do is show the system dialog instead of the preview, nothing else, so it should be the equivalent of clicking "print using the system dialog"
Is there some simple way to do that without bringing along all of the other code associated with the old preview?
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/b3a6d66cd607 Remove print.tab_modal.enabled pref and old frontend print preview code. r=mstriemer
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK