1613620 - allow to remove/delete all stored logins/passwords
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1613620
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
allow to remove/delete all stored logins/passwords
Categories
(Firefox :: about:logins, enhancement, P2)
Tracking
(bug has been fixed and VERIFIED)
85 Branch
People
(Reporter: aryx, Assigned: tgiles)
References
(Depends on 3 open bugs, Blocks 1 open bug, Regressed 1 open bug)
Details
This has been asked in the support forums and chats.
Currently, it's not possible to remove all stored logins from within Firefox. Every removal of a login and requires a confirmation which becomes cumbersome (one user had 400+ logins).
Hmm… I thought we had a bug on this. I think bug 1208194 will end up being the solution though.
This is also a common issue in uninstaller surveys. Since both the uninstaller and Sync disconnection removed the option to delete data users are really stuck without us doing this ourselves.
We should first implement the warnings that Katie designed to warn in the delete confirmation dialog when Sync is setup so users know the data will be deleted from all devices.
UX and other engineers came to a consensus on a particular case: primary password will not prompt after confirming to delete all logins. This is consistent with the current behavior of deleting a login. Primary passwords prevents snooping, but does not prevent other destructive operations.
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/20a2fcd59084 Provide an option to remove all logins at once from about:logins. r=prathiksha,fluent-reviewers,sfoster,markh
I'm the author of this patch, clearing the NI for Prathiksha. Will investigate
Pushed by [email protected]: https://hg.mozilla.org/integration/autoland/rev/552acbcfb43c Provide an option to remove all logins at once from about:logins. r=prathiksha,fluent-reviewers,sfoster,markh
This new functionality is tracked in PI-832. We have verified the new functionality and also performed regression testing on Windows 10 x64, Mac OS 10.15.6 and Ubuntu 20.04 x64.
- Here is the link with the test run used for verifying this functionality: Test Rail
- Here is a link with the Test Report sent for Nightly 85: Gdoc.
Considering this and the fact that the issues we have encountered are logged separately, I will mark this one as Verified - Fixed and I will remove the "qe-verify" flag.
However, we will re-test this functionality on the Beta 85 cycle and we will send another Test Report.
Hi Cosmin, thanks for the test rail and the report. One test case that I'm not seeing (feel free to correct me) is ensuring that the logins-backup.json
in the user's profile is deleted when a user removes all their logins. If you already know how to do this, ignore the following:
The easiest way that I know of to check this is by:
- Go to
about:support
- Click on "Open Folder" on the "Profile Folder" row
- Ensure that there is no
logins-backup.json
Adding this test case for remove all is important, since we don't want to lie to the user when we say that we've deleted all their logins..but then have a copy that is just hanging around.
Hi Tim, thanks for looking over the test cases. This is a very good scenario and unfortunately, we didn't add it in the test cases. However, we started updating the test cases and will include this scenario.
Meanwhile, we have verified this scenario on the latest Nightly 85.0a1 build (Build ID: 20201201215301) on Windows 10 x64, macOS 10.15 and Linux Mint 20.
Here are the results:
- Not logged into FxA account:
- the
logins-backup.json
file is deleted after removing all logins.
- Logged into a FxA account:
- the
logins-backup.json
file is NOT deleted after removing all logins. However, it is removed after Signing Out from the account.
@Tim, please let me know if this is intended or we should log an issue to track this.
Hey Cosmin, thanks for getting back to me on this. I believe the FxA case is expected behavior since there is a "login" that exists (since the user is logged into a FxA account, there exists a FxA sync key) even though there are no logins available to the user. Since we have a login stored, we create a backup.
Thanks for confirming this. I have verified the logins-backup.json
file and indeed there is only the FxA sync key in it.
We have also added this in our test cases on the FxA account part.
Should this be part of the release notes for 85? If yes please set the relnote-firefox
flag on this bug, with some suggested text if possible.
Release Note Request (optional, but appreciated)
[Why is this notable]: Being able to remove all logins has been a highly requested feature for over a year.
[Affects Firefox for Android]: no
[Suggested wording]: This feature allows a user to delete their logins with one click, as opposed to having to delete each login individually.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK