1

1677247 - Replace :not(:is(X)) with :not(X) in the codebase

 3 years ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1677247
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Closed Bug 1677247 Opened 1 month ago Closed 24 days ago

Replace :not(:is(X)) with :not(X) in the codebase

Categories

(Toolkit :: Themes, task)

Tracking

(bug RESOLVED as FIXED)

RESOLVED FIXED

85 Branch

Tracking Status firefox85 --- fixed

People

(Reporter: ntim, Assigned: ikartikgautam, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Summary: Replace :not(:is(X)) with :not(X) → Replace :not(:is(X)) with :not(X) in the codebase
Mentor: emilio
Keywords: good-first-bug
Whiteboard: [lang=css]

I would like to take this. Can you please guide me, as it is my first time i am contributing.
Should i replace it from every place listed in the link you have provided above?

Thank You,
Kartik Gautam

Flags: needinfo?(ntim.bugs)

(In reply to Kartik Gautam from comment #1)

I would like to take this. Can you please guide me, as it is my first time i am contributing.

Hi Kartik! You can check out https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html for an overview of all you need to make your first patch. Please let me or Emilio know if you have more specific questions.

Should i replace it from every place listed in the link you have provided above?

Everything that's not in the "Test files" category in the link should be replaced.

Flags: needinfo?(ntim.bugs)

Can You please help me, i am confused what should be commit message.
Is below message okay ?
hg commit -m "Bug 1677247 Replace :not(:is(X)) with :not(X) in the codebase. r?xyzabc"
And whom should i add as reviewer ?

Thank You,
Kartik Gautam

Flags: needinfo?(ntim.bugs)

(In reply to Kartik Gautam from comment #3)

Can You please help me, i am confused what should be commit message.
Is below message okay ?
hg commit -m "Bug 1677247 Replace :not(:is(X)) with :not(X) in the codebase. r?xyzabc"
And whom should i add as reviewer ?

Looks fine, emilio should be a good reviewer for this patch.
Also, most people usually add the dash between the bug number and the first word.

So: hg commit -m "Bug 1677247 - Replace :not(:is(X)) with :not(X) in the codebase. r?emilio"

Flags: needinfo?(ntim.bugs)
Assignee: nobody → ikartikgautam
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK