53

Google Camera HDR+ - Post #0

 6 years ago
source link: https://forum.xda-developers.com/showpost.php?p=75118407&%3Bpostcount=252
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Google Camera HDR+

thavishalovesme

Senior Member
Aug 11, 2014
I tried it on s7 exynos. the rear camera works well, but when I open the front camera the app is forced close.any solution?
Still no on every version, hoping for a fix soon.

Malik_Fajj

Member
Oct 25, 2017
Still no on every version, hoping for a fix soon.

Wait and hope ???

ChangeToTower

Senior Member
Sep 14, 2017
I got Portrait mode going on SG7 exynos. Only 1 line needed to be changed (changed image format from RAW10 to RAW_SENSOR). You need to focus on a face to have any effect obviously.

https://drive.google.com/open?id=1zaYbOcWcpkFoIkBuDbyiizKh1hCHBELw

Recommended config:
Model: Nexus 6
Portrait mode on all models: on
camera.af.debug.show: off
camera.faceboxes: on

Still need to test it on a more distant target... It gave me a bit of haircut, but it is not that bad.
So test pic:

https://drive.google.com/open?id=1aNHwsrV2C3-Ue7zQhD2XEXR7jiJipNxU
Force closes when trying to switch to front camera.

BatMan ROM 1.5, TGP Kernel, S7E

miniuser123

Senior Member
Aug 17, 2012 1,641
Force closes when trying to switch to front camera.

BatMan ROM 1.5, TGP Kernel, S7E
I only fixed portrait mode...

Reactions: aminevsaziz

UXELLR

Senior Member
Apr 22, 2011
I got Portrait mode going on SG7 exynos. Only 1 line needed to be changed (changed image format from RAW10 to RAW_SENSOR). You need to focus on a face to have any effect obviously.

https://drive.google.com/open?id=1zaYbOcWcpkFoIkBuDbyiizKh1hCHBELw

Recommended config:
Model: Nexus 6
Portrait mode on all models: on
camera.af.debug.show: off
camera.faceboxes: on

Still need to test it on a more distant target... It gave me a bit of haircut, but it is not that bad.
So test pic:

https://drive.google.com/open?id=1aNHwsrV2C3-Ue7zQhD2XEXR7jiJipNxU
Hi, could you try to do the same with this version? Better autofocus in this APK.
https://androidfilehost.com/?fid=889964283620768293
what about front cam? Haven't seen any GC over the internet with extsd support. Is it even doable?

Odesláno z mého SM-G930F pomocí Tapatalk

gorillalaci

Senior Member
May 26, 2016
Slowmo isnt Working..any Help?

Trainer_H

Senior Member
Jul 4, 2007
I got Portrait mode going on SG7 exynos. Only 1 line needed to be changed (changed image format from RAW10 to RAW_SENSOR). You need to focus on a face to have any effect obviously.

https://drive.google.com/open?id=1zaYbOcWcpkFoIkBuDbyiizKh1hCHBELw

Recommended config:
Model: Nexus 6
Portrait mode on all models: on
camera.af.debug.show: off
camera.faceboxes: on

Still need to test it on a more distant target... It gave me a bit of haircut, but it is not that bad.
So test pic:

https://drive.google.com/open?id=1aNHwsrV2C3-Ue7zQhD2XEXR7jiJipNxU
wow nice. where did you change it?
In the first time, portrait mode works but now every time i try to use this mode i got a fc. (perhaps there is a ram problem)

Reactions: aminevsaziz

miniuser123

Senior Member
Aug 17, 2012 1,641
wow nice. where did you change it?
In the first time, portrait mode works but now every time i try to use this mode i got a fc. (perhaps there is a ram problem)
Changed dio.smali line 175 to const/16 v1, 0x20.
I tested portrait mode today. The bokeh effect looks a bit fake sometimes ( it looks obvious from the shots that no depth information is used only some sophisticated picture analyser algorithm decides what to blur) but it still manages to greatly enhance the quality of photos. The blur applied is not too strong so if the algorithm misses somewhat it is not that apperant. All in all if you want to make nice photos of people especially in good light, GCam is a much better choice than the stock samsung app. I made some shots today and results reminded me of pics taken with my sony rx100.

Now the BAD thing: there is definately a problem with memory usage.
-Well over 1 gig of ram is used when taking a shot which is not normal I think.
EDIT: a lot of graphics memory is used, no idea why, other camera apps don't do this.
-If you take 2-3 shots in quick succession about 650 MB ION memory will be leaked. Without root a reboot is needed after this. This can happen in case of normal hdr+ shots too.
-even if ION is not leaked, multitasking gets worse after a portrait shot which suggests that some kind of kernel memory is allocated and not released. At this stage I have no idea what could be this...

So unfortunately we are far away from making this stable.
Last edited: Jan 7, 2018

UXELLR

Senior Member
Apr 22, 2011
Portrait with back camera Works on exynos s8 nougat. Great work!
Con: Hangs if it doesnt recognize a face. I can live with that, but the BSG-MGC version its based on has a slow tap to focus ( 5-6 seconds). A pain for macro shots or selective focus.

Wish it was possible to find out whats making (BSG's) MGC_5.1.016_7.0+C2API_v.1.3c_AllinOne version focus so fast, and add that to your version. The con in that version is that the portrait mode is not added.

I am now using both versions with AppCloner to have the full experience. Your version just for portrait.
Last edited: Jan 7, 2018

maxbeat93

Senior Member
Nov 15, 2014
Anyone tested this on any aosp oreo roms? I've tried lineage oreo but the results was still very bad. There are plenty of noises.

miniuser123

Senior Member
Aug 17, 2012 1,641
I got Portrait mode going on SG7 exynos. Only 1 line needed to be changed (changed image format from RAW10 to RAW_SENSOR). You need to focus on a face to have any effect obviously.

https://drive.google.com/open?id=1zaYbOcWcpkFoIkBuDbyiizKh1hCHBELw

Recommended config:
Model: Nexus 6
Portrait mode on all models: on
camera.af.debug.show: off
camera.faceboxes: on

Still need to test it on a more distant target... It gave me a bit of haircut, but it is not that bad.
So test pic:

https://drive.google.com/open?id=1aNHwsrV2C3-Ue7zQhD2XEXR7jiJipNxU
Here is a more stable version, less likely to crash and leak memory. Disadvantage: you have wait longer between hdr+ and portrait shots. Use the settings in my quoted post, leave everything else on default setting.
Front cam is still no go.

https://drive.google.com/open?id=1-G7pojhQUHirxWwFuQ5WctmXC_jBYps2

thavishalovesme

Senior Member
Aug 11, 2014
Here is a more stable version, less likely to crash and leak memory. Disadvantage: you have wait longer between hdr+ and portrait shots. Use the settings in my quoted post, leave everything else on default setting.
Front cam is still no go.

https://drive.google.com/open?id=1-G7pojhQUHirxWwFuQ5WctmXC_jBYps2
Appreciate your work. ?

nvrmndryo

Senior Member
Oct 24, 2013 1,033
Here is a more stable version, less likely to crash and leak memory. Disadvantage: you have wait longer between hdr+ and portrait shots. Use the settings in my quoted post, leave everything else on default setting.
Front cam is still no go.

https://drive.google.com/open?id=1-G7pojhQUHirxWwFuQ5WctmXC_jBYps2

Tried your first app, it worked on first time, but after it fc and freezes device. Now installed your 2nd app, used same settings as previous but I can't see portrait mode even if I enabled it. And you have mentioned to change one line to raw sensor, how to do that?
I am on stock fw, exynos ver.(non root)

-* ignore portrait not working, it's working now.
* for every pic it creates new folder in gallery, is there any way to avoid this?

Last edited: Jan 8, 2018

Trainer_H

Senior Member
Jul 4, 2007
If i use HDR+ ON i can't take any picture with your new version.

YlberGashi

Member
Mar 27, 2015 Rahovec
But how close is the person supposed to be to take a portrait mode photo? It seems that it works only if the person is as near as with the lens blur feature to work. Is this the same with the pixel too?
If i use HDR+ ON i can't take any picture with your new version.

Sorry for changing topics, have you tried modded HTC cam? Works with HDR+, Front cam also works, but leaks memory the same....

Can share, if interested

Odesláno z mého SM-G930F pomocí Tapatalk

miniuser123

Senior Member
Aug 17, 2012 1,641
If i use HDR+ ON i can't take any picture with your new version.
Just checked, working for me. Maybe you should reboot because of a previous memory leak. Make sure "HDR+ parameters" is set to default.
I should probably make a version which doesn't have settings which just cause trouble on our phone.

Reactions: Drewman123

Just checked, working for me. Maybe you should reboot because of a previous memory leak. Make sure "HDR+ parameters" is set to default.
I should probably make a version which doesn't have settings which just cause trouble on our phone.

How complicated it would be to add storage access framework?

I would use this cam not being for inability to save to extsd.

Odesláno z mého SM-G930F pomocí Tapatalk

nvrmndryo

Senior Member
Oct 24, 2013 1,033
Just checked, working for me. Maybe you should reboot because of a previous memory leak. Make sure "HDR+ parameters" is set to default.
I should probably make a version which doesn't have settings which just cause trouble on our phone.

Yes that would be great. Can we do anything about every portrait pictures are making different folder in gallery?


About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK