Reduce use of LocalDefId <-> HirId maps by cjgillot · Pull Request #90146...

 2 years ago
source link: https://github.com/rust-lang/rust/pull/90146
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Copy link


rust-timer commented on Oct 22, 2021

Finished benchmarking commit (ba62448): comparison url.

Summary: This change led to large relevant mixed results shrug in compiler performance.

  • Large improvement in instruction counts (up to -2.3% on incr-patched: minor change builds of tokio-webpush-simple)
  • Large regression in instruction counts (up to 2.7% on incr-unchanged builds of match-stress-enum)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

About Joyk

Aggregate valuable and interesting links.
Joyk means Joy of geeK