3

Stabilize `-Z print-link-args` as `--print link-args` by joshtriplett · Pull Req...

 3 months ago
source link: https://github.com/rust-lang/rust/pull/91606
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is damaged, please click the button below to view the snapshot at that time.

Conversation

Copy link

Member

joshtriplett commented on Dec 6, 2021

edited

We have stable options for adding linker arguments; we should have a
stable option to help debug linker arguments.

Add documentation for the new option. In the documentation, make it clear that
the exact format of the output is not a stable guarantee.

Copy link

Collaborator

rust-highfive commented on Dec 6, 2021

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

Copy link

Member

jyn514 commented on Dec 6, 2021

r? rust-lang/compiler

@rfcbot fcp merge

Copy link

rfcbot commented on Dec 13, 2021

edited by michaelwoerister

Team member @wesleywiser has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Copy link

Contributor

petrochenkov commented on Dec 15, 2021

We actually have this option for printing something:

        --print [crate-name|file-names|sysroot|target-libdir|cfg|target-list|target-cpus|target-features|relocation-models|code-models|tls-models|target-spec-json|native-static-libs]
                        Compiler information to print on stdout

--print link-args would also fit well.

-C options are supposed to be for Codegen after all, which -Cprint-link-args is not.

Copy link

Contributor

petrochenkov commented on Dec 15, 2021

@rfcbot concern "consider changing to --print link-args"

Copy link

Member

pnkfelix commented 28 days ago

@petrochenkov this specific options has output that can depend on the source code input, right?

Is there precedent for other --print variants that depend on the source input? (Its an honest question; I'm not familiar with all the options listed, and could imagine that they all don't have such dependence, or that some do.)

Copy link

Contributor

petrochenkov commented 28 days ago

Is there precedent for other --print variants that depend on the source input?

--print native-static-libs, for example.

Copy link

Member

Author

joshtriplett commented 19 days ago

@petrochenkov --print link-args seems reasonable; I'll look at what it would take to do that.

joshtriplett

changed the title Stabilize -Z print-link-args as -C print-link-args

Stabilize -Z print-link-args as --print link-args

11 days ago

This comment has been hidden.

Copy link

Member

Author

joshtriplett commented 11 days ago

@petrochenkov Done; this PR now stabilizes -Z print-link-args as --print link-args instead.

Copy link

Contributor

petrochenkov commented 10 days ago

@rfcbot resolve "consider changing to --print link-args"

Copy link

rfcbot commented 7 days ago

bellThis is now entering its final comment period, as per the review above. bell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Assignees

cjgillot

Projects

None yet

Milestone

No milestone

Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK