Stabilize `-Z print-link-args` as `--print link-args` by joshtriplett · Pull Req...
source link: https://github.com/rust-lang/rust/pull/91606
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
We have stable options for adding linker arguments; we should have a
stable option to help debug linker arguments.
Add documentation for the new option. In the documentation, make it clear that
the exact format of the output is not a stable guarantee.
(rust-highfive has picked a reviewer for you, use r? to override)
r? rust-lang/compiler
@rfcbot fcp merge
Team member @wesleywiser has proposed to merge this. The next step is review by the rest of the tagged team members:
Concerns:
- "consider changing to
--print link-args" resolved by #91606 (comment)
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
We actually have this option for printing something:
--print [crate-name|file-names|sysroot|target-libdir|cfg|target-list|target-cpus|target-features|relocation-models|code-models|tls-models|target-spec-json|native-static-libs]
Compiler information to print on stdout--print link-args would also fit well.
-C options are supposed to be for Codegen after all, which -Cprint-link-args is not.
@rfcbot concern "consider changing to --print link-args"
@petrochenkov this specific options has output that can depend on the source code input, right?
Is there precedent for other --print variants that depend on the source input? (Its an honest question; I'm not familiar with all the options listed, and could imagine that they all don't have such dependence, or that some do.)
Is there precedent for other
--print native-static-libs, for example.
@petrochenkov --print link-args seems reasonable; I'll look at what it would take to do that.
changed the title
Stabilize -Z print-link-args as -C print-link-args
Stabilize -Z print-link-args as --print link-args
This comment has been hidden.
@petrochenkov Done; this PR now stabilizes -Z print-link-args as --print link-args instead.
@rfcbot resolve "consider changing to --print link-args"
Copy link
rfcbot commented 7 days ago
This is now entering its final comment period, as per the review above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
No milestone
Successfully merging this pull request may close these issues.
None yet
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK