Switch to using gitoxide by default for listing files by arlosi · Pull Request #...
source link: https://github.com/rust-lang/cargo/pull/13696
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Conversation
Contributor
What does this PR try to resolve?
Uses gitoxide by for listing the contents of a git repository by default. Fixes #10150
It's possible out-opt of this change with the environment variable __CARGO_GITOXIDE_DISABLE_LIST_FILES=1. This opt-out mechanism is temporary and will be removed before the next release.
How should we test and review this PR?
The newly added test fails with the git2 implementation.
added A-unstable Area: nightly unstable support S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Member
|
The conclusion from the team meeting is to have both git2 and gitoxide work in parallel, and see if there is a divergence. However, during the exploration, Arlo found that the new gitoxide implementation is more "correct" than the old one. So, before reviewing it, I'd like to make sure the team is on the same page:
@rfcbot fcp merge |
|
Team member @weihanglo has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
added proposed-final-comment-period An FCP proposal has started, but not yet signed off. disposition-merge FCP with intent to merge final-comment-period FCP — a period for last comments before action is taken
and removed proposed-final-comment-period An FCP proposal has started, but not yet signed off.
labels
Collaborator
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Member
|
To maximize the testing window, I will merge this now and update the cargo submodule by the end of this week. Thanks :) @bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Collaborator
|
☀️ Test successful - checks-actions |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
A-unstable Area: nightly unstable support Command-package disposition-merge FCP with intent to merge finished-final-comment-period FCP complete S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-cargo Team: Cargo to-announce
None yet
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK