2

Allow `cast` lints in macros by franciscoBSalgueiro · Pull Request #12631 · rust...

 3 weeks ago
source link: https://github.com/rust-lang/rust-clippy/pull/12631
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Allow cast lints in macros #12631

Conversation

closes: #11738

Removed the from_expansion guard clause for cast lints, so that these warnings can be generated for internal macros.

changelog: allow cast lints in macros

taiki-e reacted with heart emoji

Collaborator

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label

Apr 4, 2024

Member

@blyxyas blyxyas

left a comment

LGTM, thanks! ❤️
This would change the outcome so that no lints were processed on proc macros. But hey, I don't think that we want to run cast lints on proc macros anyways haha =^w^=

Member

@bors r+

Collaborator

📌 Commit ac225a3 has been approved by blyxyas

It is now in the queue for this repository.

Collaborator

⌛ Testing commit ac225a3 with merge 08dac85...

bors

merged commit 08dac85 into

rust-lang:master

Apr 4, 2024

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

blyxyas

blyxyas approved these changes
Assignees

blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cast-related lint should warn internal macros

4 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK