Only inspect user-written predicates for privacy concerns by oli-obk · Pull Requ...
source link: https://github.com/rust-lang/rust/pull/123377
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Only inspect user-written predicates for privacy concerns #123377
Conversation
Contributor
fixes #123288
Previously we looked at the elaborated predicates, which, due to adding various bounds on fields, end up requiring trivially true bounds. But these bounds can contain private types, which the privacy visitor then found and errored about.
added the beta-nominated Nominated for backporting to the compiler in the beta channel. label
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
labels
What predicate ends up mentioning a private type? Specifically, what does Foo have to do with T::Assoc?
tests/ui/privacy/generic_struct_field_projection.rs
Show resolved
I think it would be helpful if you explained what bounds are being added specifically, and why that's problematic. |
added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
labels
Contributor
Author
|
Explained the test and its problematic bounds. |
|
Thanks for the explanation. I didn't understand it had to do w/ substituted + implied bounds. @bors r+ |
added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Contributor
Author
|
@bors r=compiler-errors |
Member
|
@bors p=1 Fixes P-high issue |
Contributor
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (0fd5712): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results CyclesResults Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 669.066s -> 670.684s (0.24%) |
added the beta-accepted Accepted for backporting to the compiler in the beta channel. label
removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Successfully merging this pull request may close these issues.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK