2

Change applicability of `assigning_clones` to `Unspecified` by Kobzol · Pull Req...

 4 weeks ago
source link: https://github.com/rust-lang/rust-clippy/pull/12554
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

Contributor

Before we deal with #12473 and the borrow checker errors, I think that it would be better to downgrade this lint, since it can break code.

changelog: Change the applicability of assigning_clones to Unspecified

r? @blyxyas

rustbot

added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label

Mar 25, 2024

Member

Should we also beta-nominate this?

Member

@blyxyas blyxyas

left a comment

LGTM, thanks! ❤️

Member

@bors r+

Collaborator

📌 Commit dafb7f6 has been approved by blyxyas

It is now in the queue for this repository.

Collaborator

⌛ Testing commit dafb7f6 with merge ca6a647...
1 similar comment

bors

merged commit ca6a647 into

rust-lang:master

Mar 25, 2024

5 checks passed

Collaborator

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

Kobzol

deleted the assigning-clones-unspecified branch

March 25, 2024 21:49

Contributor

Author

Should we also beta-nominate this?

Oh, did beta branch with this? In that case probably yes.

Member

The lint was released on 1.77, released on March. It hasn't been two weeks since March 21. No need for nominating :)
Kobzol reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

blyxyas

blyxyas approved these changes
Assignees

blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK