1

Implement diagnostic translation for rustc-errors by dayo05 · Pull Request #1132...

 10 months ago
source link: https://github.com/rust-lang/rust/pull/113281
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Contributor

@dayo05 dayo05

commented

Jul 3, 2023

edited

This is my first PR to rustc yeah~

I'm going to implement diagnostic translation on rustc-errors crate.

This PR is WIP, the reason of opening this as draft, I want to show my code to prevent the issue caused by misunderstanding and also I have few questions.

Some error messages are processed by pluralize! macro which determines to use plural word or not. From now, I make two kinds of keys and combine with enum but I'm not sure is this best method to do it.

Is there any prefered method to do this? => This resolved on conversation on PR.

I'll remain to perform force-push until my first implementation looks good to me


About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK