2

print argument name in arg mismatch if possible by compiler-errors · Pull Reques...

 1 year ago
source link: https://github.com/rust-lang/rust/pull/105842
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Conversation

A bit more contextual than just /* value */, at least when the argument is named something related to its context.

The UI test cases are... not super convincing, but also they're minimized tests.

Collaborator

rustbot commented Dec 17, 2022

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

rustbot

added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 17, 2022

Contributor

petrochenkov commented Dec 18, 2022

@bors r+

Contributor

bors commented Dec 18, 2022

pushpin Commit f034cb4 has been approved by petrochenkov

It is now in the queue for this repository.

bors

added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

labels

Dec 18, 2022

bors

merged commit f5656ad into

rust-lang:master

Dec 19, 2022

10 checks passed

rust-timer

added a commit to rust-lang-ci/rust that referenced this pull request

Dec 19, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK