3
Open all tabs popup on mouse down event instead of mouse up
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1489124
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Closed
Bug 1489124
Opened 3 years ago
Closed 11 days ago
Open all tabs popup on mouse down event instead of mouse up
Categories
(Firefox :: Tabbed Browser, defect, P3)
Tracking
(regression bug RESOLVED as FIXED)
RESOLVED
FIXED
97 Branch
People
(Reporter: afnankhan, Assigned: kz04px)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0 Build ID: 20180905223809 Steps to reproduce: Click on all tabs button. Actual results: All tabs popup opens after releasing the mouse button. Expected results: The popup should open on mouse down event. It feels slow compared to other popups. Most of the button in Firefox open on mouse down button.
It would be great if you could provide small test case for this bug, so that I can try to duplicate the issue. Meanwhile I am placing this under Core:Dom Events so someone can look into it. Thanks!
Component: Untriaged → DOM: Events
Flags: needinfo?(afnankhan)
Product: Firefox → Core
This bug is about "List all tabs" button which appears when the tab bar is full. To reproduce this bug open tabs until the tab bar is full and list all tabs button appears then click on the button. The tab list popup appears on mouse up. It should appear on mouse down and before mouse up similar to other buttons like hamburger menu and library button.
Flags: needinfo?(afnankhan)
Thanks for the STR! I was able to reproduce this on User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Status: UNCONFIRMED → NEW
Ever confirmed: true
There doesn't seem to be a consistency here for when buttons and menus should activate, but I think that this should be in the Tabbed Browser component to begin with.
Component: DOM: Events → Tabbed Browser
Product: Core → Firefox
Version: 64 Branch → unspecified
Assignee: nobody → kz04px
Status: NEW → ASSIGNED
Backed out for causing mochitest failures on browser_startup_images.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://global/skin/icons/arrow-right.svg should have been shown.
Flags: needinfo?(kz04px)
Backed out for causing mochitest failures on browser_startup_images.js.
(In reply to Cristian Tuns from comment #9)
Backed out for causing mochitest failures on browser_startup_images.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://global/skin/icons/arrow-right.svg should have been shown.
The patch was redone in a different and simpler way that avoided the issue. Didn't diagnose what was actually going wrong because of this.
Flags: needinfo?(kz04px)
You need to log in
before you can comment on or make changes to this bug.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK