4

Remove sync layout flush for hamburger menu opening with proton

 2 years ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1703494
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.

Details

(Whiteboard: [proton-hamburger-menu] [priority:2a])

As discussed in bug 1703405, this is a result of the sync item now potentially wrapping and the descriptionHeightWorkaround code running for it. Some options we could investigate to fix it:

  1. if we know the width available for the text beforehand (which I think we do, because the width of the panel is fixed?), ensure it is set directly on the element to ensure the XUL code for the preferred height of the element gets it right first time.
  2. switch the element in question to an HTML equivalent that wraps (possibly combined with (1)) and ensure we don't hit it in the descriptionHeightWorkAround code.
  3. switch everything in the main view to non-XUL flexbox and see if that helps.

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK