4

Measure time to render the contents of the bookmarks toolbar to assess whether w...

 3 years ago
source link: https://bugzilla.mozilla.org/show_bug.cgi?id=1680216
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Measure time to render the contents of the bookmarks toolbar to assess whether we need placeholders (like skeleton UI)

We now delay when we render the bookmarks toolbar contents until shortly after startup. On fast machines, the difference is pretty small - the bookmarks appear practically instantaneously after the window shows. But on slower machines the difference may be more marked. We should measure it to see if we need placeholder content of sorts.

Severity: -- → S4
Priority: -- → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

Comment on attachment 9198312 [details] Data review request

Yes, in the probe definition files and the Probe Dictionary.

Yes, the Firefox telemetry opt-out.

n/a, temporary collection

Default-on

Gijs et al will renew as required.

Attachment #9198312 - Flags: data-review?(tdsmith) → data-review+

Backed out 2 changesets (bug 1680216, bug 1681138) for browser_984455_bookmarks_items_reparenting.js failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=D9O_VLW_Q0S6QCWOOkdi6Q.0&fromchange=67e673da78c5d876a49e28c31d068ba3e1d08e5d&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc1&tochange=85d196d4bbd3406d0f06baf1010b07a9525d30aa

Backout link: https://hg.mozilla.org/integration/autoland/rev/85d196d4bbd3406d0f06baf1010b07a9525d30aa

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327432509&repo=autoland&lineNumber=14220

...
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Entering test bound testOverflowingBookmarksItemsContextMenu
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Ensuring panel is ready.
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Buffered messages logged at 01:48:31
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Waiting for context menu on personal-bookmarks
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Buffered messages finished
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | uncaught exception - TypeError: can't access property "buildContextMenu", menupopup._view is null at placesContextShowing@resource:///modules/PlacesUIUtils.jsm:1350:5
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - onpopupshowing@chrome://browser/content/browser.xhtml:1:22
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - synthesizeMouseAtPoint@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:594:32
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - synthesizeMouse@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:526:10
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - synthesizeMouseAtCenter@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:701:10
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - checkPlacesContextMenu/<@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:47:16
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - checkPlacesContextMenu@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:60:5
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - testOverflowingBookmarksItemsContextMenu@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:244:9
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - 
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - Stack trace:
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:2112
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtPoint:594
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouse:526
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtCenter:701
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:checkPlacesContextMenu/<:47
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:checkPlacesContextMenu:60
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:testOverflowingBookmarksItemsContextMenu:244
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - GECKO(9900) | JavaScript error: resource:///modules/PlacesUIUtils.jsm, line 1350: TypeError: can't access property "buildContextMenu", menupopup._view is null
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - Console message: [JavaScript Error: "TypeError: can't access property "buildContextMenu", menupopup._view is null" {file: "resource:///modules/PlacesUIUtils.jsm" line: 1350}]
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - placesContextShowing@resource:///modules/PlacesUIUtils.jsm:1350:5
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - onpopupshowing@chrome://browser/content/browser.xhtml:1:22
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - synthesizeMouseAtPoint@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:594:32
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - synthesizeMouse@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:526:10
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - synthesizeMouseAtCenter@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:701:10
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - checkPlacesContextMenu/<@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:47:16
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - checkPlacesContextMenu@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:60:5
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - testOverflowingBookmarksItemsContextMenu@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:244:9
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - 
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - TEST-PASS | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | New bookmark item shouldn't be disabled - 
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - Closing context menu
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - Waiting for overflow
[task 2021-01-22T01:48:31.220Z] 01:48:31     INFO - GECKO(9900) | [Child 2772, Main Thread] WARNING: Scrolled rect smaller than scrollport?: file /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp:6984
[task 2021-01-22T01:48:31.220Z] 01:48:31     INFO - GECKO(9900) | [Child 2772, Main Thread] WARNING: Scrolled rect smaller than scrollport?: file /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp:6984
[task 2021-01-22T01:48:31.220Z] 01:48:31     INFO - GECKO(9900) | [Child 2772, Main Thread] WARNING: Scrolled rect smaller than scrollport?: file /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp:6984
[task 2021-01-22T01:48:31.305Z] 01:48:31     INFO - TEST-PASS | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | Item with ID personal-bookmarks should no longer be in the gNavBar - 
[task 2021-01-22T01:48:31.305Z] 01:48:31     INFO - TEST-PASS | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | Item with ID personal-bookmarks should be overflowing - 
[task 2021-01-22T01:48:31.305Z] 01:48:31     INFO - TEST-PASS | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | Item with ID personal-bookmarks should have overflowedItem attribute - 
[task 2021-01-22T01:48:31.309Z] 01:48:31     INFO - Waiting until we stop overflowing
...

report

Recommend

About Joyk


Aggregate valuable and interesting links.
Joyk means Joy of geeK