Notifier Component by fabpot · Pull Request #33687 · symfony/symfony · GitHub
source link: https://github.com/symfony/symfony/pull/33687
Go to the source link to view the article. You can view the picture content, updated content and better typesetting reading experience. If the link is broken, please click the button below to view the snapshot at that time.
Wirone commented on Oct 4, 2019 •
@fabpot @nicolas-grekas Side question: why are you amending changes all the time? In this case it's impossible to see changes introduced on each step of the review process, so when new version of a branch is pushed I don't know what should be reviewed again (Github marks whole files as "changed since last view", with large files it's difficult to read whole file every time). I recommend adding new commits and squash them just before merging, if you want to keep compact history.
Edit: ahh, Github generates compare view for those pushes, but they're linked under "force pushed" and it's not intuitive and transparent since text is not decorated in any way. In Gitlab there is "Compare with previous version" link, much easier to notice.
Recommend
About Joyk
Aggregate valuable and interesting links.
Joyk means Joy of geeK